(CAT-2130) Pin json to prevent issues #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` Failure/Error: require 'json' ArgumentError: wrong number of arguments (given 1, expected 0) ``` As of the release of json v2.7.3 the above error has been occurring across the entirety of the PDK test environment.
|
ruby/json#646 (comment) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1410 +/- ##
=======================================
Coverage 88.49% 88.49%
=======================================
Files 127 127
Lines 5320 5320
=======================================
Hits 4708 4708
Misses 612 612 ☔ View full report in Codecov by Sentry. |
pmcmaw
changed the title
|
Associated issue on json: ruby/json#646 |
|
Failures are expected, they are present on main and a followup PR will handle them |
pmcmaw
approved these changes
Oct 25, 2024
david22swan
added
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of the release of json v2.7.3 the above error has been occurring across the entirety of the PDK test environment.
Checklist